-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Reorderable lists component #1905
Conversation
7da65e0
to
b9d1a81
Compare
8317225
to
5660c52
Compare
5660c52
to
99228dd
Compare
99228dd
to
5708a2f
Compare
5708a2f
to
43c14e4
Compare
43c14e4
to
d51648f
Compare
d51648f
to
b7a9347
Compare
b7a9347
to
db68e89
Compare
db68e89
to
90f6669
Compare
90f6669
to
8aa73aa
Compare
Nice one putting this together Dilwoar. I do still think there needs to be more consolidation between the two implementations rather than having options for all. Nikin is available to have a meeting tomorrow to work towards this consolidation. @alex-ju do you have any recollections for why Content Publisher made particular design decisions and or opinions on any parts where the collections-publisher designer is an improvement? as I understand the difference's we've got are:
|
Hi both, I don't have strong opinions on this, but I can provide a bit of background being involved with both:
Some of my design-related recollections of this during the Content Publisher times, in relation to the above points:
I share the view that having as fewer options as possible would be ideal. |
What
A list of items that can be reordered
List items can be reordered by drag and drop or by using the up/down buttons. On small viewports the drag and drop feature is disabled to prevent being triggered when scrolling on touch devices.
This component uses SortableJS - a JavaScript library for drag and drop interactions. When JavaScript is disabled a set of inputs will be shown allowing users to provide an order index for each item.
Why
This is used by publishing tools to allow reordering of lists such as steps in step by step, entries in timelines and order of visual presentation of attachments.
Disclaimer
This is a port/extension of the work that @alex-ju has done on the content publisher app.
Demo
https://govuk-publis-add-reorde-g116bw.herokuapp.com/component-guide/reorderable_list
Visual Changes
No JS view
https://trello.com/c/SD4pLfen/1086-add-reorder-component-to-govukpublishingcomponents