Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion to absorb Design System #1897

Closed
chris-gds opened this issue Jan 29, 2021 · 1 comment · Fixed by #2581
Closed

Accordion to absorb Design System #1897

chris-gds opened this issue Jan 29, 2021 · 1 comment · Fixed by #2581

Comments

@chris-gds
Copy link
Contributor

chris-gds commented Jan 29, 2021

What?

Further to this discussion, Work to improve the Accordion might feed back into the Design System. Once the Design System is updated (due in March 2021) the isolation and divergence within the gem should be removed so that the gem imports / uses the Design System as it previously did. In other words this work should be temporary + reverted.

Why?

The Design System is the single source of truth, this divergence leads to maintenance issues as this has to be maintained in two places. Also any updates to the Design System might not cascade down the same way. For example, if links styles are been updated this component won't receive them.

@owenatgov
Copy link
Contributor

A note on bespoke functionality within our accordion

We recently had to include bespoke functionality for navigating between accordions on manuals. Broad details on this feature and how it's implemented can be found here. There's a couple of questions to be answered about this feature:

  • Do the design system want this to be included in their codebase when we feed this back to them?
  • If the answer to the above is no, where do we put the additional functionality?
  • Is this feature even a good idea at all?

@chris-gds chris-gds linked a pull request Feb 1, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants