Prevent asking users to authenticate twice #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the problem with prototypes asking for username/password twice. The problem is caused by the ordering in the middleware. When a user types in the URL for a prototype like http://govuk-tagging.herokuapp.com they're asked for a username/password first (via `utils.basicAuth`). After filling that in they'll be able to "proceed" to the next step, which redirects them to the `https://` version (via `utils.forceHttps`). Because the auth isn't shared between `http` and `https` version, they are not authenticated anymore and have to enter their username/password again. Validated with https://test-prevent-double-auth.herokuapp.com/
|
thanks @tijmenb ! |
Merged
rpowis
pushed a commit
to hmrc/govuk_prototype_kit
that referenced
this pull request
Jan 31, 2017
https://raw.githubusercontent.com/alphagov/govuk_frontend_toolkit/master /CHANGELOG.md # 5.0.1 - Fix role="button" click shim ([PR alphagov#347](alphagov/govuk_frontend_toolkit#347)) - Make font variables lowercase ([PR alphagov#348](alphagov/govuk_frontend_toolkit#348)) - Update selection button documentation ([PR alphagov#350](alphagov/govuk_frontend_toolkit#350))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem with prototypes asking for username/password twice.
The problem is caused by the ordering in the middleware. When a user types in the URL for a prototype like http://govuk-tagging.herokuapp.com they're asked for a username/password first (via
utils.basicAuth).After filling that in they'll be able to "proceed" to the next step, which redirects them to the
https://version (viautils.forceHttps). Because the auth isn't shared betweenhttpandhttpsversion, they are not authenticated anymore and have to enter their username/password again.Validated with http://test-prevent-double-auth.herokuapp.com/
Before
After