Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form focus states not identical in all browsers #324

Closed
ghost opened this issue Oct 5, 2016 · 3 comments
Closed

Form focus states not identical in all browsers #324

ghost opened this issue Oct 5, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 5, 2016

While perusing some Government websites on different browsers I noticed that form focus states are not identical in all browsers.

See below screen recording, and note the browsers.

govuk

(tested on Windows and Mac, but recording was on Windows)

What is the intended design?

@edwardhorsford
Copy link
Contributor

@NickColley I think it fixes it.

@gemmaleigh
Copy link
Contributor

gemmaleigh commented Oct 27, 2016

These focus styles are set by the govuk_template, once PR #259 has been merged, the steps to fix this for govuk_elements are:

  • Bump the version of govuk_template
  • Update the version of govuk_template_jinja that govuk_elements is using to pull in this change
  • Update _govuk-template-base.scss, this file duplicates the base styles set by govuk_template, for anyone consuming govuk-elements-sass without govuk-template.

@robinwhittleton
Copy link
Contributor

Will be fixed in the next release. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants