Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we set a default font size of 19px on main? #546

Closed
joelanman opened this issue Jul 10, 2018 · 8 comments
Closed

Should we set a default font size of 19px on main? #546

joelanman opened this issue Jul 10, 2018 · 8 comments
Labels
🕔 Days A few unknowns, but we roughly know what’s involved. Feature Request User requests a new feature Partially refined

Comments

@joelanman
Copy link
Contributor

joelanman commented Jul 10, 2018

Elements used to set a default font size of 19px on the main element, this is our default font size for text on GOV.UK.

In the new prototype kit, we are using global styles to set <p> to 19px, but other elements would be 16px. A good example would be someone adding an <a> element to their prototype - the font size will be wrong by default.

@NickColley
Copy link
Contributor

Potentially we would consider extending the global styles to mirror Elements if there is a need?

@dashouse
Copy link

Before we do this it will need to be considered along with alphagov/govuk-frontend#858 which introduces a root-font-size variable for a conversion to rems.

Won't make any difference to this specific problem but the implementation should probably wait.

This is an interesting problem though, to some degree I think we have considered <a>'s would be implemented inside <p>'s or <li>'s and not so much on their own. We used to set a size on them, but that didn't make sense when they were inside a paragraph or heading as they need to inherit that size.

@hannalaakso
Copy link
Member

For context: user of prototype kit noticed that font size of links on Task list is not being set.

@dashouse
Copy link

Isn't that an issue with app-task-list__task-name not having the font size defined?

@joelanman
Copy link
Contributor Author

possibly, but they used to get their font size from 19px being set on main

@timpaul timpaul added 🕔 Days A few unknowns, but we roughly know what’s involved. Feature Request User requests a new feature Priority: low labels May 20, 2019
@ruthhammond
Copy link

Let's talk to Frontend team about this.

@ruthhammond
Copy link

Should this be addressed by global styles in Frontend?

@joelanman
Copy link
Contributor Author

closing as it has not come up recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Days A few unknowns, but we roughly know what’s involved. Feature Request User requests a new feature Partially refined
Projects
None yet
Development

No branches or pull requests

6 participants