Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to update a prototype that is already on GitHub #1207

Closed
hannalaakso opened this issue Dec 20, 2021 · 7 comments
Closed

Document how to update a prototype that is already on GitHub #1207

hannalaakso opened this issue Dec 20, 2021 · 7 comments
Labels
🕔 Days A few unknowns, but we roughly know what’s involved.

Comments

@hannalaakso
Copy link
Member

Related documentation

https://govuk-prototype-kit.herokuapp.com/docs/updating-the-kit

Suggestion

We should consider adding some extra instructions to the update tutorial if the prototype was already on GitHub so that other people who have a local copy of the prototype get the changed files.

Steps to add (draft)

  • Branch off the main (or equivalent) branch and pull down the latest changes
    [...]
  • Once the update has completed locally, commit the files and open a PR etc., depending on the process that the team working on the prototype follows

Evidence (where applicable)

A user who was updating prototypes that were already on GitHub said that it wasn't clear that after the update was complete, they needed to commit and push up the changed files.

@trang-erskine trang-erskine added 🕔 Days A few unknowns, but we roughly know what’s involved. and removed awaiting triage labels Feb 15, 2022
@EoinShaughnessy
Copy link
Contributor

@joelanman Should the 'Steps to add' go inside 'Updating to Version 12'? Or should they go into a new section, titled something like 'Updating a prototype that's already on GitHub'?

@EoinShaughnessy EoinShaughnessy self-assigned this Feb 28, 2022
@lfdebrux
Copy link
Member

lfdebrux commented Mar 1, 2022

@EoinShaughnessy ignore my last (now deleted comment), I had got myself confused.

I think you are right, this should go in 'Updating to Version 12', maybe with a small qualifier beforehand saying 'if you are using git/GitHub'

@EoinShaughnessy
Copy link
Contributor

Thanks @lfdebrux! Would these steps go at the end of the current procedure, or somewhere inside it?

@lfdebrux
Copy link
Member

lfdebrux commented Mar 1, 2022

@EoinShaughnessy at the end, they should make sure they've completed the update and everything is still working before committing and pushing changes.

@EoinShaughnessy
Copy link
Contributor

@lfdebrux Thanks! I'll raise a PR shortly.

@EoinShaughnessy
Copy link
Contributor

I closed the PR I'd raised, as we don't know whether this issue has affected more than one user so far. Maybe one to revisit when we have more evidence it's causing problems.

@JonJMagee
Copy link

Following review the Prototype Team are closing this ticket. If the original author wishes to raise this issue again please feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Days A few unknowns, but we roughly know what’s involved.
Projects
None yet
Development

No branches or pull requests

5 participants