From 1c128ef375cdaccf96ce04cf456a282d4a79374f Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 5 Jul 2018 13:45:01 +0100 Subject: [PATCH 1/2] Fix phase banner being affected by global styles When global styles are enabled, the phase banner uses the wrong font size. This is because the font-size of 16px is currently set on the parent `.govuk-phase-banner`, but `p.govuk-phase-banner__content` doesn't have a `font-size` set, so inherits the font size from the global paragraph styling. Moving the font-size declaration onto `.phase-banner__content` fixes this. --- src/components/phase-banner/_phase-banner.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/phase-banner/_phase-banner.scss b/src/components/phase-banner/_phase-banner.scss index bb9ca3c695..fc9ec56bc2 100644 --- a/src/components/phase-banner/_phase-banner.scss +++ b/src/components/phase-banner/_phase-banner.scss @@ -6,9 +6,6 @@ @include govuk-exports("govuk/component/phase-banner") { .govuk-phase-banner { - @include govuk-font($size: 16); - @include govuk-text-colour; - padding-top: govuk-spacing(2); padding-bottom: govuk-spacing(2); @@ -16,6 +13,9 @@ } .govuk-phase-banner__content { + @include govuk-font($size: 16); + @include govuk-text-colour; + display: table; margin: 0; } From d0bd02f356f7a5e2e468217a29782975b7c086ec Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 5 Jul 2018 13:46:36 +0100 Subject: [PATCH 2/2] Document in CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0898a3e062..81ca36ee74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -64,6 +64,10 @@ they will still see a circle even if the background is removed. ([PR #852](https://github.com/alphagov/govuk-frontend/pull/852)) +- Fixes a bug where the phase banner incorrectly uses a font-size of 19px when + global styles are enabled + ([PR #877}])https://github.com/alphagov/govuk-frontend/pull/877 + 🏠 Internal: - Fix Design System url in package READMEs and review app