From 0a608edb4df053034f5cc491c1dbae826e55e5c0 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 24 May 2018 16:07:09 +0100 Subject: [PATCH 1/2] Ensure 'after' tests are not ignored After tests are only used to test the result of other tasks, for example building the `dist/` folder. --- package.json | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/package.json b/package.json index 27de3557ab..2d4c360e2c 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "release": "node bin/check-nvmrc.js && ./bin/release.sh", "build:package": "node bin/check-nvmrc.js && gulp build:package --destination 'package' && npm run test:build:package", "build:dist": "node bin/check-nvmrc.js && gulp build:dist --destination 'dist' && npm run test:build:dist", - "test": "standard && gulp test && gulp copy-assets && jest", + "test": "standard && gulp test && gulp copy-assets && jest --testPathIgnorePatterns='after-*'", "test:build:package": "jest tasks/gulp/__tests__/after-build-package.test.js", "test:build:dist": "jest tasks/gulp/__tests__/after-build-dist.test.js" }, @@ -85,10 +85,6 @@ ] }, "jest": { - "testPathIgnorePatterns": [ - "/node_modules/", - "after-*" - ], "setupTestFrameworkScriptFile": "./config/jest-setup.js", "snapshotSerializers": [ "jest-serializer-html" From 6000f5c4fc0609ce5eab214478bee2ba1a0a24db Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Tue, 29 May 2018 10:45:04 +0100 Subject: [PATCH 2/2] Add CHANGELOG entry --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e49c1c9cbd..9fda5031a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,9 @@ Internal: - Fix CI timeouts: run Jest single thread in TravisCI ([PR #712](https://github.com/alphagov/govuk-frontend/pull/712)) +- Ensure 'after' tests are not ignored + ([PR #720](https://github.com/alphagov/govuk-frontend/pull/720)) + ## 0.0.29-alpha (Breaking release) Breaking changes: