Fix GOV.UK logo not being exposed consistently with VoiceOver/Safari #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoiceOver on macOS does not expose the GOV.UK `title` element in the Web Rotor's list of links, although it will announce it audibly when the link or graphic is focused. Adding an `aria-label` to the SVG ensures that VO has text it can use for the Rotor.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4497
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 70be4b7 |
colinrotherham
approved these changes
Nov 24, 2023
frankieroberto
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Nov 28, 2023
From the a PR on `govuk-frontend`: > In testing the new lockup in various accessibility tools, I found that VoiceOver on macOS does not expose the SVG's title element in the Web Rotor's list of links, although it will announce it audibly when the link or graphic is focused. > > Additionally, VoiceOver on iOS only announced the 'GOV.UK' text if the logo graphic was by itself. It omitted it if there was other text (such as a product name) within the same link. > > Adding an aria-label to the SVG seems to rectify both of these issues. It doesn't appear to have side effects in any other screen readers that I tested or when VO announces the link or graphic audibly. alphagov/govuk-frontend#4497
frankieroberto
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Nov 28, 2023
From the a PR on `govuk-frontend`: > In testing the new lockup in various accessibility tools, I found that VoiceOver on macOS does not expose the SVG's title element in the Web Rotor's list of links, although it will announce it audibly when the link or graphic is focused. > > Additionally, VoiceOver on iOS only announced the 'GOV.UK' text if the logo graphic was by itself. It omitted it if there was other text (such as a product name) within the same link. > > Adding an aria-label to the SVG seems to rectify both of these issues. It doesn't appear to have side effects in any other screen readers that I tested or when VO announces the link or graphic audibly. alphagov/govuk-frontend#4497
Closed
3 tasks
owenatgov
pushed a commit
that referenced
this pull request
Jan 11, 2024
Fix GOV.UK logo not being exposed consistently with VoiceOver/Safari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing the new lockup in various accessibility tools, I found that VoiceOver on macOS does not expose the SVG's
titleelement in the Web Rotor's list of links, although it will announce it audibly when the link or graphic is focused.Additionally, VoiceOver on iOS only announced the 'GOV.UK' text if the logo graphic was by itself. It omitted it if there was other text (such as a product name) within the same link.
Adding an
aria-labelto the SVG seems to rectify both of these issues. It doesn't appear to have side effects in any other screen readers that I tested or when VO announces the link or graphic audibly.Comparison
Taking screenshots of VoiceOver's GUI isn't easy in macOS, so here's a table of how the link is exposed by VoiceOver in Safari 17.1 on macOS 13.6.