Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(packages): copy changes to packages #437

Merged
merged 3 commits into from
Jan 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ Note: We're not following semantic versioning yet, we are going to talk about th

Breaking changes:

New features:

- Button hover colour now has a semantic Sass name: $govuk-button-hover-colour (PR [#406](https://github.com/alphagov/govuk-frontend/pull/406))

Fixes:

Internal:

## 0.0.22-alpha (Breaking release)

Breaking changes:

- The link styles in the core layer no longer style `a` elements directly, but
instead provide a `govuk-link` class which you will need to apply to links
individually. (PR [#427](https://github.com/alphagov/govuk-frontend/pull/427))
Expand All @@ -23,7 +35,6 @@ New features:
- The muted link variant from the link component is now available as a core
class (`govuk-link--muted`).
(PR [#427](https://github.com/alphagov/govuk-frontend/pull/427))
- Button hover colour now has a semantic Sass name: $govuk-button-hover-colour (PR [#406](https://github.com/alphagov/govuk-frontend/pull/406))

Fixes:

Expand All @@ -42,9 +53,11 @@ Fixes:

Internal:

- Add prose scope example (PR [#429](https://github.com/alphagov/govuk-frontend/pull/429))
- Links within the review app and the examples have been updated to use the
`govuk-link` class.
(PR [#427](https://github.com/alphagov/govuk-frontend/pull/427))
- Improve documentation around publishing (PR [#430](https://github.com/alphagov/govuk-frontend/pull/430))
- Improve documentation around contributing (PR [#433](https://github.com/alphagov/govuk-frontend/pull/433))

## 0.0.21-alpha (Breaking release)
Expand Down
3 changes: 1 addition & 2 deletions packages/all/_all.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
@import "@govuk-frontend/file-upload/file-upload";
@import "@govuk-frontend/input/input";
@import "@govuk-frontend/label/label";
@import "@govuk-frontend/legal-text/legal-text";
@import "@govuk-frontend/link/link";
@import "@govuk-frontend/panel/panel";
@import "@govuk-frontend/phase-banner/phase-banner";
@import "@govuk-frontend/tag/tag";
Expand All @@ -26,3 +24,4 @@
@import "@govuk-frontend/table/table";
@import "@govuk-frontend/textarea/textarea";
@import "@govuk-frontend/previous-next/previous-next";
@import "@govuk-frontend/warning-text/warning-text";
51 changes: 25 additions & 26 deletions packages/all/package.json
Original file line number Diff line number Diff line change
@@ -1,31 +1,30 @@
{
"name": "@govuk-frontend/all",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/back-link": "^0.0.21-alpha",
"@govuk-frontend/breadcrumbs": "^0.0.21-alpha",
"@govuk-frontend/button": "^0.0.21-alpha",
"@govuk-frontend/checkboxes": "^0.0.21-alpha",
"@govuk-frontend/cookie-banner": "^0.0.21-alpha",
"@govuk-frontend/date-input": "^0.0.21-alpha",
"@govuk-frontend/details": "^0.0.21-alpha",
"@govuk-frontend/error-message": "^0.0.21-alpha",
"@govuk-frontend/error-summary": "^0.0.21-alpha",
"@govuk-frontend/fieldset": "^0.0.21-alpha",
"@govuk-frontend/file-upload": "^0.0.21-alpha",
"@govuk-frontend/icons": "^0.0.21-alpha",
"@govuk-frontend/input": "^0.0.21-alpha",
"@govuk-frontend/label": "^0.0.21-alpha",
"@govuk-frontend/legal-text": "^0.0.21-alpha",
"@govuk-frontend/link": "^0.0.21-alpha",
"@govuk-frontend/panel": "^0.0.21-alpha",
"@govuk-frontend/phase-banner": "^0.0.21-alpha",
"@govuk-frontend/previous-next": "^0.0.21-alpha",
"@govuk-frontend/radios": "^0.0.21-alpha",
"@govuk-frontend/select": "^0.0.21-alpha",
"@govuk-frontend/skip-link": "^0.0.21-alpha",
"@govuk-frontend/table": "^0.0.21-alpha",
"@govuk-frontend/tag": "^0.0.21-alpha",
"@govuk-frontend/textarea": "^0.0.21-alpha"
"@govuk-frontend/back-link": "^0.0.22-alpha",
"@govuk-frontend/breadcrumbs": "^0.0.22-alpha",
"@govuk-frontend/button": "^0.0.22-alpha",
"@govuk-frontend/checkboxes": "^0.0.22-alpha",
"@govuk-frontend/cookie-banner": "^0.0.22-alpha",
"@govuk-frontend/date-input": "^0.0.22-alpha",
"@govuk-frontend/details": "^0.0.22-alpha",
"@govuk-frontend/error-message": "^0.0.22-alpha",
"@govuk-frontend/error-summary": "^0.0.22-alpha",
"@govuk-frontend/fieldset": "^0.0.22-alpha",
"@govuk-frontend/file-upload": "^0.0.22-alpha",
"@govuk-frontend/icons": "^0.0.22-alpha",
"@govuk-frontend/input": "^0.0.22-alpha",
"@govuk-frontend/label": "^0.0.22-alpha",
"@govuk-frontend/panel": "^0.0.22-alpha",
"@govuk-frontend/phase-banner": "^0.0.22-alpha",
"@govuk-frontend/previous-next": "^0.0.22-alpha",
"@govuk-frontend/radios": "^0.0.22-alpha",
"@govuk-frontend/select": "^0.0.22-alpha",
"@govuk-frontend/skip-link": "^0.0.22-alpha",
"@govuk-frontend/table": "^0.0.22-alpha",
"@govuk-frontend/tag": "^0.0.22-alpha",
"@govuk-frontend/textarea": "^0.0.22-alpha",
"@govuk-frontend/warning-text": "^0.0.22-alpha"
}
}
1 change: 1 addition & 0 deletions packages/back-link/_back-link.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

.govuk-c-back-link {
@include govuk-font-regular-16;
@include govuk-focusable-fill;

display: inline-block;
position: relative;
Expand Down
4 changes: 2 additions & 2 deletions packages/back-link/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/back-link",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
5 changes: 5 additions & 0 deletions packages/breadcrumbs/_breadcrumbs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@
content: none;
display: none;
}

.govuk-c-breadcrumbs__link {
@include govuk-focusable-fill;
}

.govuk-c-breadcrumbs__link:link,
.govuk-c-breadcrumbs__link:visited,
.govuk-c-breadcrumbs__link:hover,
Expand Down
6 changes: 3 additions & 3 deletions packages/breadcrumbs/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "@govuk-frontend/breadcrumbs",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha",
"@govuk-frontend/icons": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha",
"@govuk-frontend/icons": "^0.0.22-alpha"
}
}
2 changes: 1 addition & 1 deletion packages/button/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -380,4 +380,4 @@ Guidelines can be found at [on our Github repository.](https://github.com/alphag

## License

MIT
MIT
6 changes: 3 additions & 3 deletions packages/button/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "@govuk-frontend/button",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha",
"@govuk-frontend/icons": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha",
"@govuk-frontend/icons": "^0.0.22-alpha"
}
}
6 changes: 3 additions & 3 deletions packages/checkboxes/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "@govuk-frontend/checkboxes",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha",
"@govuk-frontend/label": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha",
"@govuk-frontend/label": "^0.0.22-alpha"
}
}
4 changes: 2 additions & 2 deletions packages/cookie-banner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ More information about when to use cookie-banner can be found on [GOV.UK Design
#### Markup

<div class="govuk-c-cookie-banner js-cookie-banner">
<p class="govuk-c-cookie-banner__message">GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies">Find out more about cookies</a></p>
<p class="govuk-c-cookie-banner__message">GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies" class="govuk-link">Find out more about cookies</a></p>
</div>

#### Macro

{{ govukCookieBanner({
"html": "GOV.UK uses cookies to make the site simpler. <a href=\"https://www.gov.uk/help/cookies\">Find out more about cookies</a>"
"html": "GOV.UK uses cookies to make the site simpler. <a href=\"https://www.gov.uk/help/cookies\" class=\"govuk-link\">Find out more about cookies</a>"
}) }}

## Dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/cookie-banner/cookie-banner.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

<div class="govuk-c-cookie-banner js-cookie-banner">
<p class="govuk-c-cookie-banner__message">GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies">Find out more about cookies</a></p>
<p class="govuk-c-cookie-banner__message">GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies" class="govuk-link">Find out more about cookies</a></p>
</div>

2 changes: 1 addition & 1 deletion packages/cookie-banner/cookie-banner.njk
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% from "cookie-banner/macro.njk" import govukCookieBanner %}

{{ govukCookieBanner({
'html': 'GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies">Find out more about cookies</a>'
'html': 'GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies" class="govuk-link">Find out more about cookies</a>'
}) }}
4 changes: 2 additions & 2 deletions packages/cookie-banner/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/cookie-banner",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
18 changes: 9 additions & 9 deletions packages/date-input/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,23 @@ More information about when to use date-input can be found on [GOV.UK Design Sys
Day

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-day" name="dob-day" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-day" name="dob-day" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--month">
<label class="govuk-c-label govuk-c-date-input__label" for="dob-month">
Month

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-month" name="dob-month" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-month" name="dob-month" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--year">
<label class="govuk-c-label govuk-c-date-input__label" for="dob-year">
Year

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-year" name="dob-year" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-year" name="dob-year" type="text">
</div>

</div>
Expand Down Expand Up @@ -192,15 +192,15 @@ More information about when to use date-input can be found on [GOV.UK Design Sys
Month

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-day-error-month" name="dob-day-error-month" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-day-error-month" name="dob-day-error-month" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--year">
<label class="govuk-c-label govuk-c-date-input__label" for="dob-day-error-year">
Year

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-day-error-year" name="dob-day-error-year" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-day-error-year" name="dob-day-error-year" type="text">
</div>

</div>
Expand Down Expand Up @@ -258,7 +258,7 @@ More information about when to use date-input can be found on [GOV.UK Design Sys
Day

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-month-error-day" name="dob-month-error-day" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-month-error-day" name="dob-month-error-day" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--month">
Expand All @@ -274,7 +274,7 @@ More information about when to use date-input can be found on [GOV.UK Design Sys
Year

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-month-error-year" name="dob-month-error-year" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-month-error-year" name="dob-month-error-year" type="text">
</div>

</div>
Expand Down Expand Up @@ -332,15 +332,15 @@ More information about when to use date-input can be found on [GOV.UK Design Sys
Day

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-year-error-day" name="dob-year-error-day" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-year-error-day" name="dob-year-error-day" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--month">
<label class="govuk-c-label govuk-c-date-input__label" for="dob-year-error-month">
Month

</label>
<input class="govuk-c-input govuk-c-date-input__input undefined" id="dob-year-error-month" name="dob-year-error-month" type="text">
<input class="govuk-c-input govuk-c-date-input__input" id="dob-year-error-month" name="dob-year-error-month" type="text">
</div>

<div class="govuk-c-date-input__item govuk-c-date-input__item--year">
Expand Down
8 changes: 4 additions & 4 deletions packages/date-input/package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "@govuk-frontend/date-input",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/error-message": "^0.0.21-alpha",
"@govuk-frontend/globals": "^0.0.21-alpha",
"@govuk-frontend/label": "^0.0.21-alpha"
"@govuk-frontend/error-message": "^0.0.22-alpha",
"@govuk-frontend/globals": "^0.0.22-alpha",
"@govuk-frontend/label": "^0.0.22-alpha"
}
}
4 changes: 2 additions & 2 deletions packages/details/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/details",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
4 changes: 2 additions & 2 deletions packages/error-message/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/error-message",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
6 changes: 5 additions & 1 deletion packages/error-summary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@ More information about when to use error-summary can be found on [GOV.UK Design
<ul class="govuk-list govuk-c-error-summary__list">

<li>

<a href="#example-error-1">Descriptive link to the question with an error</a>

</li>

<li>
<a href="#example-error-1"></a>

<a href="#example-error-1">Descriptive link to the question with an error</a>

</li>

</ul>
Expand Down
5 changes: 5 additions & 0 deletions packages/error-summary/_error-summary.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
margin-top: 0;
margin-bottom: 0;
}

.govuk-c-error-summary__list a {
@include govuk-focusable-fill;
}

.govuk-c-error-summary__list a:link,
.govuk-c-error-summary__list a:visited,
.govuk-c-error-summary__list a:hover,
Expand Down
4 changes: 2 additions & 2 deletions packages/error-summary/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/error-summary",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
6 changes: 5 additions & 1 deletion packages/error-summary/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@
<ul class="govuk-list govuk-c-error-summary__list">
{% for item in params.errorList %}
<li>
<a href="{{item.href}}">{{item.text}}</a>
{% if item.href %}
<a href="{{ item.href }}">{{ item.html | safe if item.html else item.text }}</a>
{% else %}
{{ item.html | safe if item.html else item.text }}
{% endif %}
</li>
{% endfor %}
</ul>
Expand Down
4 changes: 2 additions & 2 deletions packages/fieldset/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@govuk-frontend/fieldset",
"version": "0.0.21-alpha",
"version": "0.0.22-alpha",
"dependencies": {
"@govuk-frontend/globals": "^0.0.21-alpha"
"@govuk-frontend/globals": "^0.0.22-alpha"
}
}
Loading