Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set an explicit button type, and bump html-validate from 8.2.0 to 8.3.0 #4113

Merged
merged 2 commits into from
Sep 4, 2023

Commits on Aug 30, 2023

  1. Bump html-validate from 8.2.0 to 8.3.0

    Bumps [html-validate](https://gitlab.com/html-validate/html-validate) from 8.2.0 to 8.3.0.
    - [Release notes](https://gitlab.com/html-validate/html-validate/tags)
    - [Changelog](https://gitlab.com/html-validate/html-validate/blob/master/CHANGELOG.md)
    - [Commits](https://gitlab.com/html-validate/html-validate/compare/v8.2.0...v8.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: html-validate
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    fa83143 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Update Button params.type to match the documentation

    Our documentation says Button components as `<button>` should always default `params.type` to `submit`:
    
    > Type of `input` or `button` – `button`, `submit` or `reset`. Defaults to `submit`. This has no effect on `a` elements.
    
    Rather than rely on `<button>` to implicitly default to `type="submit"` we should set it in the HTML
    colinrotherham committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    95366f7 View commit details
    Browse the repository at this point in the history