-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to Prototype Kit plugin config #4101
Conversation
Ahh this is brilliant, thank you @nataliecarey We've got a spike open at the moment which will eventually include GOV.UK Prototype Kit in our automated tests: Would you mind if I included these changes in that PR? Once v5 testing is complete we'll switch to managing |
bf4fa61
to
19c3df5
Compare
Ahh I've tried it with the
So we'll hold off on my last suggestion until But this is still really useful so I've pushed up some config tweaks from the spike too |
19c3df5
to
e4b1efe
Compare
e4b1efe
to
1092e42
Compare
1092e42
to
5a86bc8
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 596d962 |
@colinrotherham looks good to me. |
We're working on a new plugin page, we'll be making use of new metadata that comes from plugin config. This PR adds that metadata.
I've also added the validator to the post-build tests, this uses
npx
and@latest
to always look at the latest requirements. I recommend this approach but it does erode the purity of repeatable builds, you could hardcode a version number in there or installgovuk-prototype-kit
as a (dev) dependency and remove bothnpx
and@latest
.I've not added any tests or a strict type definition because I've added the validator which imposes the rules more strictly than any test I'd be contributing here.