Add changelog for v3.6.0 (unreleased) release #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1756
hannalaakso
reviewed
Mar 4, 2020
There was a problem hiding this comment.
LGTM. @m-green would you be okay to add a note about https://github.com/alphagov/govuk-frontend/pull/1711/files#r387609856? 🙏
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1756
|
@hannalaakso Added the note about |
hannalaakso
approved these changes
Mar 4, 2020
m-green
commented
Mar 4, 2020
|
Looks great @m-green 👍 |
36degrees
reviewed
Mar 5, 2020
|
|
||
| [Pull request #1723: Add display override for hiding content when printing](https://github.com/alphagov/govuk-frontend/pull/1723). | ||
|
|
||
| #### The `iff` Sass function is now deprecated |
There was a problem hiding this comment.
Very much non-blocking, thinking out loud… should we consider splitting deprecations out into their own section? This isn't really a new feature.
There was a problem hiding this comment.
Might be an idea for a future version? I'm not sure about giving them a whole section to themselves, but maybe a subsection somewhere...
5 tasks
36degrees
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the full edited version of the v3.6.0 release note in CHANGELOG.md.
Please review for:
Following review and before publication we need to: