Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs result in a flash of unstyled content as the page loads #927

Closed
NickColley opened this issue Jul 24, 2018 · 2 comments · Fixed by #1000
Closed

Tabs result in a flash of unstyled content as the page loads #927

NickColley opened this issue Jul 24, 2018 · 2 comments · Fixed by #1000
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@NickColley
Copy link
Contributor

Similar to the problem we had with conditional reveals if the JavaScript is slow to load tabs will be shown stacked in a broken fashion.

You can see a simulation of this in this closed PR #917
@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jul 24, 2018
@NickColley
Copy link
Contributor Author

I have a WIP branch for this: https://github.com/alphagov/govuk-frontend/compare/fix-fouc-with-tabs-panels

Main thing I think we'd need to introduce is being able to set an initial active state for tabs.

@adamsilver
Copy link
Contributor

adamsilver commented Jul 26, 2018 •
edited
Loading

Originally I had it so that the default active state (unless in the location hash) is the first tab. Did that get carried through when it was published?

@NickColley NickColley mentioned this issue Sep 14, 2018
Merged
@NickColley NickColley mentioned this issue Oct 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flash of unstyled content in tabs component alphagov/govuk-frontend
2 participants
@adamsilver @NickColley