Conditional reveal aria-hidden/display none being used

[adamsilver]

Currently, the [aria-hidden=true] attribute/selector is being used to visually hide the conditional panel when clicking a checkbox or radio button.

My thinking is that we can just use .js-hidden which will stop a potential flicker and hide the panel for both sighted users and screen reader users without having to have special attributes just for AT.

[NickColley]

I believe originally we tried .js-hidden and hidden but then moved towards [aria-hidden=true] to avoid problems but I confess to have forgotten what that problem was.

Think if there's not good reason, using hidden makes sense. 👍

[adamsilver]

Oh I know what that might be, @NickColley. The reveal is based on checkbox/radio checked state. So js-hidden might bugger that by hiding it regardless of state.

I would still suggest that a simple .hidden will hide it from everyone without having to use AT specific attributes. Admittedly this is a bit nit-picky.

[NickColley]

We resolved this by using a modifier rather than a global class in #885

Thanks for raising Adam