Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles conflict with skip link component #4930

Closed
MatMoore opened this issue Apr 10, 2024 · 3 comments · Fixed by #4936
Closed

Global styles conflict with skip link component #4930

MatMoore opened this issue Apr 10, 2024 · 3 comments · Fixed by #4936
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) skip link
Milestone

Comments

@MatMoore
Copy link

MatMoore commented Apr 10, 2024

Description of the issue

When $govuk-global-styles is set to true in Sass, the underline is missing from skip links.

$govuk-global-styles applies govuk-focus-text to all links, which removes underline and adds box-shadow.

But the skip link component removes box shadow in this case, without adding back in the underline.

We are using global styles because our service contains some content that is rendered from markdown, and we cannot easily apply the proper classes to the generated HTML.

To get the underline I need to manually add some extra CSS.

Steps to reproduce the issue

  • Compile the GOV.UK frontend Sass with $govuk-global-styles set to true
  • View a page with a skip link
  • Navigate to the skip link by keyboard

Actual vs expected behaviour

Actual - no underline
Screenshot showing the skip link with no underline

Expected
Screenshot showing the skip link with underline added back in

Environment (where applicable)

  • Operating system: MacOS
  • Browser: Chrome
  • Browser version: 123.0.6312.59
  • GOV.UK Frontend Version: 5.1.0
@MatMoore MatMoore added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Apr 10, 2024
Copy link

Uh oh! @MatMoore, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@RokeJulianLockhart

This comment was marked as off-topic.

@querkmachine
Copy link
Member

Thanks for bringing this to our attention @MatMoore! 😺

@owenatgov owenatgov added this to the 5.3.1 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) skip link
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants