Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Remove input variant from button component #492

Closed
NickColley opened this issue Feb 1, 2018 · 5 comments
Closed

Discussion: Remove input variant from button component #492

NickColley opened this issue Feb 1, 2018 · 5 comments

Comments

@NickColley
Copy link
Contributor

Following on from the conversation here alphagov/govuk_elements#545.

It seems that input style buttons are only useful in IE6/7, since we do not support these browsers should we remove this from our macro and reduce complexity in the component?

@NickColley NickColley changed the title Remove input from button component Remove input variant from button component Feb 1, 2018
@NickColley NickColley changed the title Remove input variant from button component Request for comments: Remove input variant from button component Feb 1, 2018
@NickColley NickColley changed the title Request for comments: Remove input variant from button component Discussion: Remove input variant from button component Feb 1, 2018
@36degrees
Copy link
Contributor

I think we should definitely consider making <button> the default behaviour. I'm less sure whether we should remove the support for <input> entirely.

@NickColley
Copy link
Contributor Author

Can you explain what issues you can think of that would prevent us from removing input support?

@36degrees
Copy link
Contributor

Only really that IE7 bug - whilst we may not 'support' older browsers, using a <button> on a form where multiple buttons are provided could cause confusing behaviour in IE7.

I'm fine with not caring about how it looks in those browsers, but removing <input> support entirely makes it harder for teams to correct it.

@NickColley
Copy link
Contributor Author

NickColley commented Feb 1, 2018

As part of our migration guidance from elements, we could include how to replace input elements with buttons, would this be acceptable? Since consumers of elements will have to change their markup regardless.

One other thing to consider is when people port the macros, if they have less complexity it'll make it a lot easier for them.

@NickColley
Copy link
Contributor Author

NickColley commented Feb 1, 2018

Had a look into what we could suggest to move away from inputs, doesn't look too easy (without resulting to JavaScript) so, seems OK to compromise on changing the default instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants