-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Remove input
variant from button component
#492
Comments
input
from button componentinput
variant from button component
input
variant from button componentinput
variant from button component
input
variant from button componentinput
variant from button component
I think we should definitely consider making |
Can you explain what issues you can think of that would prevent us from removing input support? |
Only really that IE7 bug - whilst we may not 'support' older browsers, using a I'm fine with not caring about how it looks in those browsers, but removing |
As part of our migration guidance from elements, we could include how to replace input elements with buttons, would this be acceptable? Since consumers of elements will have to change their markup regardless. One other thing to consider is when people port the macros, if they have less complexity it'll make it a lot easier for them. |
Had a look into what we could suggest to move away from inputs, doesn't look too easy (without resulting to JavaScript) so, seems OK to compromise on changing the default instead. |
Following on from the conversation here alphagov/govuk_elements#545.
It seems that input style buttons are only useful in IE6/7, since we do not support these browsers should we remove this from our macro and reduce complexity in the component?
The text was updated successfully, but these errors were encountered: