Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors during Skip Link initialisation if key HTML elements are missing #4128

Closed
1 task
Tracked by #3478
domoscargin opened this issue Aug 24, 2023 · 0 comments · Fixed by #4177
Closed
1 task
Tracked by #3478

Throw errors during Skip Link initialisation if key HTML elements are missing #4128

domoscargin opened this issue Aug 24, 2023 · 0 comments · Fixed by #4177
Assignees
@domoscargin
Labels
javascript skip link
Milestone
v5.0

Comments

@domoscargin
Copy link
Contributor

What

Update our JavaScript components requiring specific HTML elements to be present so they throw a MissingElementError (extending GOVUKFrontendError) rather than silently fail:

  • The linked element

Why

This is part of our work to have our components throw rather than silently return during initialisation.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Component has been updated to throw errors
@domoscargin domoscargin moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Aug 24, 2023
@domoscargin domoscargin added this to the v5.0 milestone Aug 24, 2023
This was referenced Aug 24, 2023
Closed
Closed
@domoscargin domoscargin self-assigned this Sep 5, 2023
@domoscargin domoscargin moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Sep 5, 2023
@domoscargin domoscargin mentioned this issue Sep 5, 2023
Merged
@domoscargin domoscargin moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Sep 5, 2023
@domoscargin domoscargin moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Sep 7, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoscargin domoscargin

Labels
javascript skip link
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Add MissingElementError and use it within the Skip Link alphagov/govuk-frontend
1 participant
@domoscargin