Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break build when change impacts on file sizes/modules content is too big #3286

Open
3 tasks
Tracked by #3279
romaricpascal opened this issue Feb 13, 2023 · 0 comments
Open
3 tasks
Tracked by #3279

Comments

@romaricpascal
Copy link
Member

Part of #3279

What

Automatically break the build when the changes introduced in a branch yield too big an impact on file sizes/modules content.

Why

It'll make it easier to spot big impacts, and make consistent from one PR to another what's considered as such.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've gathered data from multiple PRs about what's a "normal" impact on file size/modules content
  • We've decided on criteria for what constitutes too big a change 1
  • A Github workflow breaks the build when changes meet those criteria 2

Footnotes

  1. We'll likely want to consider comparing relative changes, rather than absolute ones

  2. We'll need to design a way to get the PR to go through anyway, as the large variation may be justified (eg. new component, big tidy-up...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants