Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare file sizes between branches #3284

Open
3 tasks
Tracked by #3279
romaricpascal opened this issue Feb 13, 2023 · 0 comments
Open
3 tasks
Tracked by #3279

Compare file sizes between branches #3284

romaricpascal opened this issue Feb 13, 2023 · 0 comments

Comments

@romaricpascal
Copy link
Member

Part of #3279

What

Compare built files sizes in PR between the tip of the branch it'll be merged into.

Potentially reduce the comment on the PR to list only what's changed (the stats would still be available in the review app).

Why

Comparing manually is possible, but requires us to remember to do it at all times. Doing it automatically will help ensure it happens and let us focus on what changed rather than spend effort figuring what's the same and what's different.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • File sizes are compared on PR 1
  • Possibly PR comment is updated to only show what changed
  • Something is in place to handle the base branch begin updated 2

Footnotes

  1. This will likely call for keeping track of the sizes on the base branch rather than re-computing each time (either in Github action cache, as Git note or something else)

  2. Github will re-run workflows when we push to the PR branch. If something changes on the base branch, though, we'll need to find a way to re-compute things (either automatically or have some info like the Git SHA that lets us infer that the stats are correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants