Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions config to work with Prototype Kit v13 #2889

Closed
8 tasks
36degrees opened this issue Sep 29, 2022 · 4 comments · Fixed by #2851 or #2981
Closed
8 tasks

Update extensions config to work with Prototype Kit v13 #2889

36degrees opened this issue Sep 29, 2022 · 4 comments · Fixed by #2851 or #2981
Milestone

Comments

@36degrees
Copy link
Contributor

What

Update the extensions config file and add any additional integration points required for GOV.UK Frontend to work correctly in (the future) v13 of the Prototype Kit.

Why

A new major version of the Prototype Kit will shortly be released which includes some changes to the extension system that affect us.

Specifically, the kit will no longer:

So, we now need to provide the integration points to take care of those things, some of which relies on new functionality in v13 of the Prototype Kit – some of which may not yet be stable. This means we'll need to work closely with the Prototype Kit team to ensure that what we end up releasing will work with v13.0.0 of the Prototype Kit.

Who needs to work on this

Developers

Who needs to review this

Developers, Developers from the Prototype Kit team

Done when

  • We've confirmed what the stable 'API' for the Prototype Kit extensions system will look like
  • The extensions config and supporting files, when included in the Prototype Kit, takes care of:
    • importing the Nunjucks macros for all components
    • configuring the asset paths
    • enabling the new link styles
    • turning on global styles
    • calling window.GOVUKFrontend.initAll
  • We've shared a pre-release of GOV.UK Frontend with the Prototype team and they have confirmed that it works as expected
@36degrees 36degrees added this to the [NEXT] milestone Sep 29, 2022
@36degrees 36degrees linked a pull request Sep 29, 2022 that will close this issue
@36degrees
Copy link
Contributor Author

@nataliecarey is open to pairing on this.

She has already raised a PR that could be updated (#2851)

@colinrotherham colinrotherham self-assigned this Oct 14, 2022
@36degrees
Copy link
Contributor Author

How should we record this change in the changelog and release notes, if at all?

Arguably it's a new feature but it doesn't seem relevant for folks reading the release notes as it's more about unlocking a feature of the Prototype Kit?

Maybe we should include it in fixes? 'Add support for Prototype Kit v13 plugin system'?

@colinrotherham
Copy link
Contributor

Reopening until changelog and release notes added

@colinrotherham colinrotherham reopened this Nov 4, 2022
@colinrotherham
Copy link
Contributor

Just included it under "Fixes" as discussed: #2981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants