Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated govuk-!-margin-static and govuk-!-padding-static classes #2782

Closed
1 task done
Tracked by #3524
vanitabarrett opened this issue Aug 17, 2022 · 0 comments · Fixed by #3593
Closed
1 task done
Tracked by #3524

Remove deprecated govuk-!-margin-static and govuk-!-padding-static classes #2782

vanitabarrett opened this issue Aug 17, 2022 · 0 comments · Fixed by #3593
Assignees
@querkmachine
Labels
breaking change sass / css
Milestone
v5.0

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Aug 17, 2022 •
edited by querkmachine
Loading

What

In v4.3.1 we added the govuk-!-static classes alongside the incorrectly named govuk-!-margin-static and govuk-!-padding-static classes and marked those incorrect ones as deprecated. We should remove the deprecated classes in our next breaking release (v5.0.0)

Why

We said in the v4.3.1 release notes that we were deprecating the govuk-!-margin-static and govuk-!-padding-static classes and that we'd remove them in a future breaking release. We should stick to what we said and actually do it.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Remove the incorrectly ordered static spacing override classes here and here
@vanitabarrett vanitabarrett added the awaiting triage Needs triaging by team label Aug 17, 2022
@vanitabarrett vanitabarrett added this to the v5.0 milestone Aug 17, 2022
@vanitabarrett vanitabarrett added breaking change sass / css and removed awaiting triage Needs triaging by team labels Aug 17, 2022
@36degrees 36degrees mentioned this issue Apr 18, 2023
Closed
@querkmachine querkmachine self-assigned this May 9, 2023
@querkmachine querkmachine mentioned this issue May 9, 2023
Merged
@querkmachine querkmachine moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board May 9, 2023
@querkmachine querkmachine moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board May 9, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@querkmachine querkmachine

Labels
breaking change sass / css
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated static spacing classes alphagov/govuk-frontend
2 participants
@querkmachine @vanitabarrett