Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error summary focus styles not meeting contrast requirements #2748

Closed
NickColley opened this issue Aug 4, 2022 · 3 comments
Closed

Error summary focus styles not meeting contrast requirements #2748

NickColley opened this issue Aug 4, 2022 · 3 comments
Labels
awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@NickColley
Copy link
Contributor

Not sure on this one? The yellow on it's own was determined to not be good enough so thats why the black border was added to components.

Screenshot 2022-08-04 at 3 18 25 pm

I feel like this definitely was considered but I can't remember why we didnt do something like this:

Screenshot 2022-08-04 at 3 21 19 pm

Does it already work well and I'm overlooking something?

@NickColley NickColley added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Aug 4, 2022
@36degrees
Copy link
Contributor

Hi @NickColley 👋🏻

I think this might be covered by #1936? Can you take a look and see if you think it covers it?

@NickColley
Copy link
Contributor Author

Hello :) Aye it is! Thanks :)

@NickColley
Copy link
Contributor Author

My personal feeling is it's useful for the focus to be more visible so you know why you've been moved to this element as you could be like, why am I here. Whereas you'd be more aware of I'm focusing on this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

2 participants