Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor linting tasks to remove Gulp #2710

Closed
4 of 5 tasks
domoscargin opened this issue Jul 20, 2022 · 3 comments · Fixed by #2916
Closed
4 of 5 tasks

Refactor linting tasks to remove Gulp #2710

domoscargin opened this issue Jul 20, 2022 · 3 comments · Fixed by #2916
Labels

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jul 20, 2022

What

Update tasks/gulp/lint.js to replace Gulp with our own lint scripts. There are two tasks in this file, one to lint SCSS and one to lint JS. Note that we currently spawn a process to run the linting tasks. We could probably tidy this up a bit.

Why

We have made the decision to move away from Gulp and write our own build scripts.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • tasks/gulp/lint.js no longer sdepends on Gulp
  • standard and stylelint are as up to date as feasible
  • docs/contributing/tasks.md has been updated
  • NPM scripts lint, lint:js and lint:scss work correctly
  • lint.js has been relocated to tasks folder
@domoscargin domoscargin added awaiting triage Needs triaging by team 🕔 days tooling and removed awaiting triage Needs triaging by team labels Jul 20, 2022
@domoscargin domoscargin self-assigned this Aug 16, 2022
@domoscargin domoscargin removed their assignment Aug 16, 2022
@colinrotherham
Copy link
Contributor

I've struck off the last "Done when" task as we no longer need a separate lint.js file for 'lint:scss'

We have a new task helper npmScriptTask() which calls npm scripts directly:

/**
 * Umbrella styles tasks (for watch)
 * Runs Sass code quality checks and compilation
 */
gulp.task('styles', gulp.series(
  npmScriptTask('lint:scss', ['--silent']),
  'scss:compile'
))

@colinrotherham colinrotherham self-assigned this Oct 13, 2022
@colinrotherham
Copy link
Contributor

I've unintentionally done three of the tasks (sorry) so I'll assign myself to this one

@colinrotherham
Copy link
Contributor

✅ All our stylelint and standard packages are up to date too

There's one more related change so I've opened #2916

@colinrotherham colinrotherham removed their assignment Nov 8, 2022
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants