-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor linting tasks to remove Gulp #2710
Labels
Comments
domoscargin
added
awaiting triage
Needs triaging by team
🕔 days
tooling
and removed
awaiting triage
Needs triaging by team
labels
Jul 20, 2022
I've struck off the last "Done when" task as we no longer need a separate lint.js file for We have a new task helper /**
* Umbrella styles tasks (for watch)
* Runs Sass code quality checks and compilation
*/
gulp.task('styles', gulp.series(
npmScriptTask('lint:scss', ['--silent']),
'scss:compile'
)) |
I've unintentionally done three of the tasks (sorry) so I'll assign myself to this one |
✅ All our There's one more related change so I've opened #2916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Update
tasks/gulp/lint.js
to replace Gulp with our own lint scripts. There are two tasks in this file, one to lint SCSS and one to lint JS. Note that we currently spawn a process to run the linting tasks. We could probably tidy this up a bit.Why
We have made the decision to move away from Gulp and write our own build scripts.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
standard
andstylelint
are as up to date as feasiblelint
,lint:js
andlint:scss
work correctlylint.js has been relocated to tasks folderThe text was updated successfully, but these errors were encountered: