Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand our visual regression testing to include 'non-default' scenarios #2593

Closed
2 of 4 tasks
vanitabarrett opened this issue Apr 19, 2022 · 1 comment
Closed
2 of 4 tasks
Labels

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Apr 19, 2022

In #2070 we added Percy visual regression testing to govuk-frontend. It takes screenshots of each component with JavaScript disabled and enabled. There are other contexts which we might want to consider generating screenshots for, that will help us capture issues that we might otherwise not notice or forget to test, such as:

  • Compatibility mode
  • High contrast (don't think Percy has built-in support for this, but we could explore alternatives/workarounds)

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Brainstormed scenarios which we might want to generate screenshots for
  • Compared the scenarios we want to implement vs how much of our 100,000 monthly screenshot limit we're currently using
  • Changed the Percy test to generate additional screenshots and checked they're appearing in Percy.io as expected
  • Updated documentation
@vanitabarrett vanitabarrett added awaiting triage Needs triaging by team 🕔 days tooling and removed awaiting triage Needs triaging by team labels Apr 19, 2022
@colinrotherham
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants