Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus and hover states of product name in header are much wider than the content #2181

Open
hannalaakso opened this issue Apr 6, 2021 · 1 comment
Open

Focus and hover states of product name in header are much wider than the content #2181

hannalaakso opened this issue Apr 6, 2021 · 1 comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) design header 🕔 hours A well understood issue which we expect to take less than a day to resolve. small story

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Apr 6, 2021 •
edited
Loading

Description of the issue

The focus and hover states on the GOV.UK product name in the header are much wider than the enclosed content when the product name breaks onto a new line.

Chrome 89 on Mac OS
Screenshot 2021-04-06 at 10 51 32
Screenshot 2021-04-06 at 10 58 49

Chrome on Galaxy S21
Screenshot 2021-04-06 at 10 43 30

Actual vs expected behaviour

Focus and hover states should neatly wrap around the enclosed content.
@hannalaakso hannalaakso added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team design header labels Apr 6, 2021
@vanitabarrett vanitabarrett added 🕔 hours A well understood issue which we expect to take less than a day to resolve. small story and removed awaiting triage Needs triaging by team labels Sep 24, 2021
@owenatgov owenatgov self-assigned this Feb 16, 2022
@owenatgov owenatgov mentioned this issue Feb 16, 2022
Merged
@vanitabarrett
Copy link
Contributor

Note: the PR mentioned above will partly fix the issue on desktop, but won't address it on mobile. We should make sure this issue stays open even after the PR is merged, as it might be something to revisit when we look at other changes to the header.

@owenatgov owenatgov added this to the [NEXT] milestone Feb 17, 2022
@domoscargin domoscargin removed this from the v4.1.0 milestone May 18, 2022
@owenatgov owenatgov removed their assignment Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) design header 🕔 hours A well understood issue which we expect to take less than a day to resolve. small story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hannalaakso @domoscargin @vanitabarrett @kellylee-gds @owenatgov and others