Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional link styles to align with buttons on cookie banner #2107

Closed
5 tasks done
kellylee-gds opened this issue Dec 1, 2020 · 3 comments · Fixed by #2114
Closed
5 tasks done

Create additional link styles to align with buttons on cookie banner #2107

kellylee-gds opened this issue Dec 1, 2020 · 3 comments · Fixed by #2114
Assignees
Milestone

Comments

@kellylee-gds
Copy link
Contributor

kellylee-gds commented Dec 1, 2020

What

We now have three inline actions in the cookie banner. New styles may need to be introduced to keep all actions aligned, equally spaced and consistent.

The 'accept...' and 'reject...' actions are buttons but the 'View and set cookie preferences' action is a link and is visually different from the two buttons.

Why

Users need to understand that the three actions are related and that their cookie preferences can be altered to selectively opt in and out of additional cookie types.

Who needs to know about this

Designers, developers

Further detail

  • The focus styles for links are also different and should be looked at as part of this work.
  • The primary button padding may also need to be reviewed if it is to have consistency with the currently proposed button for rejecting cookies.

Done when

  • Decided on content for buttons and links in the cookie banner.
  • Decided on styling for the 'reject...' button within the banner.
  • Researched and documented use of button alongside links in services across gov.
  • Decided if this is an adjustment to the styles in the component or more universally to inline links.
  • Adjustments to the styles of the links and buttons to create consistency across desktop and mobile.
@CharlotteDowns CharlotteDowns self-assigned this Dec 1, 2020
@CharlotteDowns
Copy link
Contributor

CharlotteDowns commented Dec 4, 2020

Work so far

@vanitabarrett vanitabarrett transferred this issue from another repository Jan 13, 2021
@vanitabarrett vanitabarrett transferred this issue from another repository Jan 13, 2021
@vanitabarrett
Copy link
Contributor

vanitabarrett commented Jan 15, 2021

Update: there was a conversation on Slack yesterday about styling the 'Hide' link in the confirmation banner as a button instead of a link.

Cookie banner confirmation banner with a button for hide

@CharlotteDowns
Copy link
Contributor

CharlotteDowns commented Jan 20, 2021

Design decisions

Based on the working group feedback for the cookie banner we prototyped moving the 'view cookies' link onto a separate line beneath the 'accept...' and 'reject...' buttons. These prototypes use an earlier draft of the cookie banner guidance but with updated button and link content.

Inline
Accept analytics cookies button, Reject analytics cookies button and view cookies link all inline within the banner

New line
Accept analytics cookies button and Reject analytics cookies button are inline. The view cookies link takes a new line underneath within the cookie banner

We have made the decision to proceed with the inline version of the buttons and link. This makes the assumption that users may be confused about the relationship of the links with the buttons, possibly even mistaking it for an additional option or next step. If you have any feedback or user research that can help us improve on this please let us know.


Margins

We are suggesting adding the class govuk-!-margin-right-2 to the first button 'Accept analytics cookies' and no additional spacing styles to the 'Reject analytics cookies' to space the buttons equally with the margin styles of the 'View cookies' link.

Cookie banner margins between buttons and links

Other points to note:

  • We need to decide on the responsive behaviour of the inline components; two buttons and a link. A suggestion would be to wrap the buttons govuk-grid-column-full instead of govuk-grid-column-two-thirds as this only causes one break point instead of two as the screen size gets smaller.
  • The margin styles for the inline link need to change when it moves to a line on it's own.
  • We need to confirm the vertical margins between the buttons on mobile view where they take 100% width of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants