Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove govuk-tag--inactive class #1757

Closed
2 tasks done
Tracked by #2274
hannalaakso opened this issue Mar 4, 2020 · 2 comments · Fixed by #2417
Closed
2 tasks done
Tracked by #2274

Remove govuk-tag--inactive class #1757

hannalaakso opened this issue Mar 4, 2020 · 2 comments · Fixed by #2417
Assignees
Milestone

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Mar 4, 2020

What

Remove the govuk-tag--inactive class as it now duplicates what the govuk-tag--grey class does.

Why

As discussed in #1711 (comment), #1711 adds a new class govuk-tag--grey, the naming of which is inline with the other new tag colour classes.

Who needs to know about this

Developers, Tech Writer

Done when

  • govuk-tag--inactive class has been removed
  • "Details of breaking change" section below completed to help with writing release notes

Details of breaking change

  • which users are affected: If you use govuk-tag--inactive
  • the change that’s been made: govuk-tag--inactive has been removed
  • changes users will have to make: Replace govuk-tag--inactive with govuk-tag--grey
  • impact of users not making those changes: Tag will use default style instead of greyed-out style
@lfdebrux
Copy link
Member

lfdebrux commented Nov 3, 2021

I've had a go at filling out the details of breaking change in this ticket.

@lfdebrux
Copy link
Member

lfdebrux commented Nov 3, 2021

I've got a PR to remove the class, including a first pass update to the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants