Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long text in footer columns do not wrap #1647

Closed
aliuk2012 opened this issue Nov 15, 2019 · 5 comments
Closed

Long text in footer columns do not wrap #1647

aliuk2012 opened this issue Nov 15, 2019 · 5 comments
Labels
feature request User requests a new feature footer

Comments

@aliuk2012
Copy link
Contributor

While trying to implement the footer component for Digital Marketplace, we came across an issue with the footer, It doesn't seem to support long navigation text.

We wanted a three-column layout like this:

image

However, as soon as you have links with a lot of content the layout breaks into two columns and the third column overflows onto another row as in this example:

image

I think the expected behaviour should be that the link text adheres to the column width and wraps itself.

I haven't tested this out in other browsers but I did have this problem in Chrome 78.

@aliuk2012 aliuk2012 changed the title Long text in footer columns not wrap Long text in footer columns do not wrap Nov 15, 2019
@NickColley
Copy link
Contributor

We have another issue here relating to the footer layout, makes me think we should be using CSS Grid for this: #1539

@NickColley NickColley added the awaiting triage Needs triaging by team label Nov 15, 2019
@kellylee-gds kellylee-gds added Effort: days feature request User requests a new feature and removed awaiting triage Needs triaging by team labels Nov 20, 2019
@aliuk2012
Copy link
Contributor Author

Something interestingly if I reduce the window to tablet/mobile than the link text wraps.

Desktop:
image

Table/mobile

image

@aliuk2012
Copy link
Contributor Author

Looks like it might be an issue with flex-basis anything other than desktop gets flex-basis: 200px added but in desktop it is not and the li items seem to have 100% width which is why the text does not wrap on desktops.

@aliuk2012
Copy link
Contributor Author

I'll see if I can find some time to did a bit deeper into the issue but I think this is a bug and not a feature request.

@36degrees
Copy link
Contributor

We believe this was resolved by the changes in #2462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request User requests a new feature footer
Projects
None yet
Development

No branches or pull requests

4 participants