You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The button role is unnecessary for element button.
We could also consider using our button macro here - if we decide to make it possible to override govuk-button class on the component since the header button won’t be requiring those styles.
The text was updated successfully, but these errors were encountered:
36degrees
changed the title
Remove role="button" from header button
HTML validation error: "The button role is unnecessary for element button."
Jul 5, 2022
The header with navigation component sets
role="button"
on the menu button.Our button component doesn’t set this attribute but the header button is hardcoded.
<button>
is well supported so settingrole
is not useful here.The W3C Markup Validator flags it as warning
We could also consider using our button macro here - if we decide to make it possible to override
govuk-button
class on the component since the header button won’t be requiring those styles.The text was updated successfully, but these errors were encountered: