Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radios and checkboxes with empty conditionals causes odd spacing #1546

Closed
edwardhorsford opened this issue Aug 30, 2019 · 1 comment · Fixed by #1595
Closed

Radios and checkboxes with empty conditionals causes odd spacing #1546

edwardhorsford opened this issue Aug 30, 2019 · 1 comment · Fixed by #1595
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@edwardhorsford
Copy link
Contributor

Raising as separate ticket from #1494

If you have an item with a conditional and the conditional content is empty, when you select that item, you get weird spacing:
61715646-7186dd00-ad55-11e9-9e97-32f9d7ddad17

I think this is because conditional items are given margin-bottom: 20px. When the item is selected, the conditional is made visible so the margin is added.

Similar to #1494 I might check if conditional contains any items - if not, don't render it.

@edwardhorsford
Copy link
Contributor Author

To add: I think this is an edge case and very low priority. I came across it whilst building the checkboxes and allowing for conditionals - but before I'd defined the html of the conditionals yet.

I thought you might come across it if you wanted to make the conditional itself conditional on a statement, but I think something like this works anyway:

Screenshot 2019-08-30 at 14 34 26

@36degrees 36degrees added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Sep 2, 2019
@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting triage Needs triaging by team labels Sep 11, 2019
@36degrees 36degrees self-assigned this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
3 participants