Add tests to throw if there are JavaScript errors

alphagov · Mar 1, 2019 · 517692c · 517692c
1 parent d85dee7
commit 517692c
Show file tree

Hide file tree

Showing 7 changed files with 42 additions and 0 deletions.
diff --git a/__tests__/accessiblity_audit.test.js b/__tests__/accessiblity_audit.test.js
@@ -15,6 +15,12 @@ const thingsToExclude = [
 beforeAll(async (done) => {
   browser = global.browser
   page = await browser.newPage()
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/back-to-top.test.js b/__tests__/back-to-top.test.js
@@ -12,6 +12,12 @@ beforeAll(async (done) => {
   await page.evaluateOnNewDocument(() => {
     window.__TESTS_RUNNING = true
   })
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/component-options.test.js b/__tests__/component-options.test.js
@@ -9,6 +9,12 @@ let baseUrl = 'http://localhost:' + PORT
 beforeAll(async (done) => {
   browser = global.browser
   page = await browser.newPage()
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/example.test.js b/__tests__/example.test.js
@@ -12,6 +12,12 @@ beforeAll(async (done) => {
   await page.evaluateOnNewDocument(() => {
     window.__TESTS_RUNNING = true
   })
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/mobile-navigation.test.js b/__tests__/mobile-navigation.test.js
@@ -15,6 +15,12 @@ beforeAll(async (done) => {
     window.__TESTS_RUNNING = true
   })
   await page.emulate(iPhone)
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/search.test.js b/__tests__/search.test.js
@@ -15,6 +15,12 @@ beforeEach(async (done) => {
   await page.evaluateOnNewDocument(() => {
     window.__TESTS_RUNNING = true
   })
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })
 

diff --git a/__tests__/tabs.test.js b/__tests__/tabs.test.js
@@ -12,6 +12,12 @@ beforeAll(async (done) => {
   await page.evaluateOnNewDocument(() => {
     window.__TESTS_RUNNING = true
   })
+
+  // Capture JavaScript errors.
+  page.on('pageerror', error => {
+    throw error
+  })
+
   done()
 })