Remove Nokogumbo dependency #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing Nokogumbo we can resolve a warning that downstream apps are emitting of "NOTE: nokogumbo: Using Nokogiri::HTML5 provided by Nokogiri. See sparklemotion/nokogiri#2205 for more information."
This version of Sanitize no longer has a dependency on Nokogumbo and will stop our apps emitting a Nokogumbo warning. Although Sanitize 5.2.3 -> 6 is a major version upgrade, the changes are very benign. With the bump given a major status due to the dropping of old Ruby versions (that this gem had already dropped) [1] [1]: https://github.com/rgrove/sanitize/blob/main/HISTORY.md#600-2021-08-03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes the Nokogumbo dependency both directly from this gem, and indirectly by updating Sanitize
Why
Nokogumbo is no longer needed as an additional dependency see: sparklemotion/nokogiri#2205. It's presence leaves a warning message each time it is required of
NOTE: nokogumbo: Using Nokogiri::HTML5 provided by Nokogiri. See https://github.com/sparklemotion/nokogiri/issues/2205 for more information.Visual Changes
None