Update rubocop-govuk requirement from ~> 3.17.1 to ~> 4.0.0 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) to permit the latest version. - [Release notes](https://github.com/alphagov/rubocop-govuk/releases) - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v3.17.1...v4.0.0) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
This is a new cop that is part of rubocop-govuk 4 that requires you to specify the minimum Ruby version a gem supports. This cop makes a lot of sense for gem distribution and clarity over which Ruby version is supported for a gem.
rubocop -A
kevindew
force-pushed
the
dependabot/bundler/rubocop-govuk-tw-4.0.0
branch
from
fbd856b to
2a45840
Compare
A recent change to govuk_publishing_components is to set display none for certain styles in print contexts [1]. These unfortunately broke a number of tests in this gem as they added extra class elements that are not in the markup of our assertions. I've resolved this for attachments by truncating what we assert on so only the first part of the class name is checked. This seems to work but is naturally a bit fragile. For the Start button elements I've temporarily added in the missing class so that the tests pass. However I think it's a little too fragile to have govuk_publishing_components HTML included verbatim so I intend to clean this up on the next commit. [1]: alphagov/govuk_publishing_components@6fe73e6
These tests were quite fragile to any changes in govuk_publishing_components as they expected the HTML from that gem to be identical to assertions. To try reduce fragility I have added a new assert selector method that can match a CSS selector. This then allows us to reduce the amount of things we assert on to reduce the coupling with the gem. In doing this I noticed that a few of the tests are basically repeats of earlier tests so removed them. I also simplified the register to vote test to not include the start button SVG to make that a little less fragile, I did this because I couldn't think of a nice quick way to assert on everything it is doing.
kevindew
force-pushed
the
dependabot/bundler/rubocop-govuk-tw-4.0.0
branch
from
a80497e to
f9948ac
Compare
chao-xian
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rubocop-govuk to permit the latest version.
Changelog
Sourced from rubocop-govuk's changelog.
... (truncated)
Commits
0f689f1Merge pull request #143 from alphagov/rubocop-4b19ba31Release version 4 of rubocop-govukc4d484dBump rubocop related gemsb2affe3Merge pull request #136 from alphagov/dependabot/add-v2-config-file0085dcaUpgrade to GitHub-native Dependabotce65577Merge pull request #131 from alphagov/better-version-numberbe6bad2Rename release of 4.0.0.pre-1 to 4.0.0.pre.1f4e7d55Merge pull request #130 from alphagov/release-4.0.0.pre-14bf3a99Release as 4.0.0.pre-10bbc40aMerge pull request #127 from alphagov/dependabot/bundler/rubocop-gte-1.7-and-...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)