Handle links that have a blank or missing href #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the markdown contains an empty markdown link `[foo]()` or it contains `a` tags with missing or empty `href` attributes we should strip them out of the list of hrefs we return. They're not valid links so there's no point in checking them. We use CSS selectors on the document to strip out any links that have no href attribute (which means we ignore valid `a` tags like `<a name="table-of-contents">ToC</a>`), but we use ruby to filter out blank `href` attributes because it's more flexible.
suzannehamilton
approved these changes
Feb 21, 2018
h-lame
added a commit
that referenced
this pull request
Feb 21, 2018
Includes: * #124 - ignoring links with a blank or missing href when extracting links
This was referenced Feb 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://trello.com/c/8mDzHj8g/84-1-links-without-href-break-whitehall
If the markdown contains an empty markdown link
[foo]()or it containsatags with missing or emptyhrefattributes we should strip them outof the list of hrefs we return. They're not valid links so there's no
point in checking them. We use CSS selectors on the document to strip
out any links that have no href attribute (which means we ignore valid
atags like<a name="table-of-contents">ToC</a>), but we use ruby tofilter out blank
hrefattributes because it's more flexible.