Add website_url arguement to Govspeak::Document#extracted_links #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebAshton
force-pushed
the
add-website-root-to-link-extractor
branch
2 times, most recently
from
ac0062c to
3e7dbfb
Compare
thomasleese
approved these changes
Jan 12, 2018
| @@ -0,0 +1,28 @@ | |||
| require "test_helper" | |||
|
|
|||
| class GovspeakLinkExtractorWithWebsiteRootTest < Minitest::Test | |||
There was a problem hiding this comment.
I would be tempted to just merge this in with the other tests for the link extractor.
SebAshton
force-pushed
the
add-website-root-to-link-extractor
branch
from
3e7dbfb to
33e5f26
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set an optional argument on
Govspeak::Document#extracted_linkswhich will mean all returned URLs are fully qualified.