Add fill and submit form feature test #517
Conversation
SamJamCul
force-pushed
the
1171-add-missing-feature-tests-to-the-runner
branch
3 times, most recently
from
8906477
to
586c757
Compare
|
@SamJamCul nice work! Please can you expand the description on the commit message. Even repeating the PR description is fine. See: https://gds-way.cloudapps.digital/standards/source-code/working-with-git.html#commit-messages and in particular https://cbea.ms/git-commit/ |
SamJamCul
force-pushed
the
1171-add-missing-feature-tests-to-the-runner
branch
from
586c757
to
4cd3ff1
Compare
Done, I've summarised the changes without as much hand-wringing as my pull request |
|
@SamJamCul the commit message itself can have a link to the issue in govuk-frontend too - it's useful background |
Adds a new feature spec which covers the basic form filler journey. It only contains one question, which is answered without triggering any validation, and the form is submitted without opting for an email confirmation. There's also a tweak to our use of the Axe clean accessibility checks, which was flagging up our use of `aria-expanded="false"`. It looks like this should be passing, and the Axe rule hasn't been changed yet to reflect this. As a result, we've ignored any triggering of this rule on radio buttons. See alphagov/govuk-frontend#979 for more details
SamJamCul
force-pushed
the
1171-add-missing-feature-tests-to-the-runner
branch
from
4cd3ff1
to
ac2c982
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Good shout! I was a bit wary of including links in commit messages, but as it's a github issue it seems silly to avoid it! |
What problem does this pull request solve?
Trello card: https://trello.com/c/BP0bsQOf/1171-add-beginnings-of-missing-feature-tests-to-the-runner
This adds a basic feature test that covers filling in and submitting a form.
There's also a change to our Axe check helper, which skips checking radio buttons for the
aria-allowed-attrrule. This is a rule that probably shouldn't be catching our use ofaria-expanded="false"as explored in this thread.I've opted to turn the email confirmation feature on in this test, as it's currently off by default. I kind of got most of the way through writing the tests before realising I'd turned it on locally, and it felt a bit pointless removing the opt-out-of-email-confirmation step in the test just because we haven't removed the feature flag yet.
The
ARIA_ALLOWED_ATTRconstant was added as sonarcloud thought it smelled funny otherwise.