Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPIKE: Create job to send emails asynchronously using Sidekiq #1059

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

SPIKE: Create job to send emails asynchronously using Sidekiq #1059

wants to merge 2 commits into from
+61 −4

Conversation

stephencdaly
Copy link
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/20YGjblm

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephencdaly stephencdaly changed the title SPIKE: Create job to send emails asynchronously SPIKE: Create job to send emails asynchronously using Sidekiq Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephencdaly @DavidBiddle