Remove flask-featureflags integration, bump flask to v0.12.4 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-flask-0-12
branch
from
3cfd7a3 to
b89b8ed
Compare
katstevens
reviewed
Aug 24, 2018
dmutils/errors.py
Outdated
| # This is the remnant of a workaround for a bug in Flask 0.10.1. In that case, CSRFErrors | ||
| # are caught under 400 BadRequest exceptions, so this handler can be registered to catch | ||
| # all 400s, but will immediately discards non-CSRFError instances. Can be removed once | ||
| # we're absolutely certain nothing is still using Flask 0.10.1. |
There was a problem hiding this comment.
I think we can remove it now. If the app has pulled in this version of utils it will have Flask 0.12, and flask_init will only supply this function with recognisable CSRFError instances (as opposed to, say, BadRequest).
There was a problem hiding this comment.
For clarity we could rename the e arg to csrf_error?
risicle
force-pushed
the
ris-flask-0-12
branch
from
b89b8ed to
c35580e
Compare
This was referenced Aug 24, 2018
risicle
force-pushed
the
ris-flask-0-12
branch
2 times, most recently
from
734d7e8 to
321abe2
Compare
…dler for CSRFError we can do this because of the upgrade to flask 0.12 fixing the bug we were working around here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ZH9trgjH/419-snyk-alert-for-flask-010x-vulnerability
This broadly does three things:
CSRFErrorhandling workaround required for flask 0.10.x's deficiency, instead registering the handler in a more obvious way.Making an upgrade to this version will require bumping the app's Flask to 0.12.4, which itself can require some changes. Luckily I've already done this for all (?) the apps and PRs should be following for them. I'll probably only merge this once people are happy with them too.