Remove apiclient and audit modules #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiclient and audit were moved to the new dmapiclient package, so local modules can be removed. `dmutils.apiclient` and `dmutils.audit` import paths are preserved for package-level names to simplify transition, but imports from apiclient modules (eg `from dmutils.apiclient.errors ....`) will have to be changed.
Since API clients use the module name as logger name it has changed after the modules were moved to the new `dmapiclient` package. The new logger has to be configured the same way we configure `dmutils`.
Forces the apps to use the new dmapiclient package name for imports
|
👍 |
allait
added a commit
that referenced
this pull request
Jan 4, 2016
Remove apiclient and audit modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove apiclient and audit modules in favour of dmapiclient
apiclient and audit were moved to the new dmapiclient package, so
local modules can be removed.
dmutils.apiclientanddmutils.auditimport paths are preservedfor package-level names to simplify transition, but imports from
apiclient modules (eg
from dmutils.apiclient.errors ....) willhave to be changed.
Configure new dmapiclient logger together with dmutils
Since API clients use the module name as logger name it has changed
after the modules were moved to the new
dmapiclientpackage.The new logger has to be configured the same way we configure
dmutils.