You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not a fan of this style of pascalCase some keys + alias to other keys
We should be opinionated, like createDownloadUrl(context, { bucket, key, filename, ttl }) or not bother doing anything for these use cases (just maybe extend the aws client?)
asserting that urlTTL exists and aliasing it to expires is weird
The text was updated successfully, but these errors were encountered:
It is not possible to have a defined set of keys since each operation takes a unique one. Unless we scrap a generic getSignedUrl and create something like createGetObjectSignedUrl.
Then we should consider naming things consistently with AWS keys, and extending clients so that we don't have to write boilerplate for every method, and allow helper methods to be defined on top -- createGetObjectSignedUrl is one way, but createDownloadUrl is another, with a bit more opinionation
https://github.com/alpha-lambda/aws-drivers/blob/master/lib/s3.js#L19
Not a fan of this style of pascalCase some keys + alias to other keys
We should be opinionated, like createDownloadUrl(context, { bucket, key, filename, ttl }) or not bother doing anything for these use cases (just maybe extend the aws client?)
asserting that urlTTL exists and aliasing it to expires is weird
The text was updated successfully, but these errors were encountered: