Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent naming/etc #8

Open
dougmoscrop opened this issue Jun 25, 2019 · 2 comments
Open

inconsistent naming/etc #8

dougmoscrop opened this issue Jun 25, 2019 · 2 comments

Comments

@dougmoscrop
Copy link

https://github.com/alpha-lambda/aws-drivers/blob/master/lib/s3.js#L19

Not a fan of this style of pascalCase some keys + alias to other keys

We should be opinionated, like createDownloadUrl(context, { bucket, key, filename, ttl }) or not bother doing anything for these use cases (just maybe extend the aws client?)

asserting that urlTTL exists and aliasing it to expires is weird

@AntonBazhal
Copy link
Member

It is not possible to have a defined set of keys since each operation takes a unique one. Unless we scrap a generic getSignedUrl and create something like createGetObjectSignedUrl.

@dougmoscrop
Copy link
Author

Then we should consider naming things consistently with AWS keys, and extending clients so that we don't have to write boilerplate for every method, and allow helper methods to be defined on top -- createGetObjectSignedUrl is one way, but createDownloadUrl is another, with a bit more opinionation

@AntonBazhal AntonBazhal reopened this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants