Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should contain_xml not working #7

Open
pzol opened this issue May 19, 2011 · 4 comments
Open

should contain_xml not working #7

pzol opened this issue May 19, 2011 · 4 comments

Comments

@pzol
Copy link

pzol commented May 19, 2011

   the xml:
    <hotels destination_code="MAD" language="de">
              <geo lat="40.419" lon="-3.706" />
   </hotels>

   should match xml:
        <geo lat="40.419" lon="-3.706" />

returns false, it should return true for contain_xml
Besides... the description of the failure message should be "should contain xml"

@alovak
Copy link
Owner

alovak commented Jun 20, 2011

do you have time to fix it?

@apotonick
Copy link
Collaborator

Yepp.

@pzol
Copy link
Author

pzol commented Jul 12, 2011

any news guys?

@apotonick
Copy link
Collaborator

According to the test file this is not supposed to work: https://github.com/alovak/test_xml/blob/ab6c2d6ac4bbbf315eceeb680e0e96f4470752d0/test/test_unit/test_assertions.rb

However, "contain" implies that we're only interested in a contained markup fragment, right? Currently, the assertion tests if any of the contained nodes are within the expected markup. So, what is the expected behaviour of "contains"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants