From e220a1f743c4f68ac460f71faea5757359644c86 Mon Sep 17 00:00:00 2001 From: Hayden Shively <17186559+haydenshively@users.noreply.github.com> Date: Wed, 11 Oct 2023 21:58:21 -0500 Subject: [PATCH] Correct function signature in periphery managers (#188) --- periphery/src/managers/BoostManager.sol | 2 +- periphery/src/managers/FrontendManager.sol | 2 +- periphery/src/managers/SimpleManager.sol | 2 +- periphery/src/managers/UniswapNFTManager.sol | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/periphery/src/managers/BoostManager.sol b/periphery/src/managers/BoostManager.sol index aeab6dd4..3bb962c0 100644 --- a/periphery/src/managers/BoostManager.sol +++ b/periphery/src/managers/BoostManager.sol @@ -33,7 +33,7 @@ contract BoostManager is IManager, IUniswapV3SwapCallback { borrower.transfer(amount0 > 0 ? uint256(amount0) : 0, amount1 > 0 ? uint256(amount1) : 0, msg.sender); } - function callback(bytes calldata data, address owner) external override returns (uint144) { + function callback(bytes calldata data, address owner, uint208) external override returns (uint208) { // We cast `msg.sender` as a `Borrower`, but it could really be anything. DO NOT TRUST! Borrower borrower = Borrower(payable(msg.sender)); diff --git a/periphery/src/managers/FrontendManager.sol b/periphery/src/managers/FrontendManager.sol index e878bdb5..504d6056 100644 --- a/periphery/src/managers/FrontendManager.sol +++ b/periphery/src/managers/FrontendManager.sol @@ -28,7 +28,7 @@ contract FrontendManager is IManager, IUniswapV3SwapCallback { /* solhint-disable code-complexity */ - function callback(bytes calldata data, address owner) external returns (uint144 positions) { + function callback(bytes calldata data, address owner, uint208) external returns (uint208 positions) { // We cast `msg.sender` as a `Borrower`, but it could really be anything. DO NOT TRUST! Borrower account = Borrower(payable(msg.sender)); diff --git a/periphery/src/managers/SimpleManager.sol b/periphery/src/managers/SimpleManager.sol index 02394975..ff2cd1f9 100644 --- a/periphery/src/managers/SimpleManager.sol +++ b/periphery/src/managers/SimpleManager.sol @@ -4,7 +4,7 @@ pragma solidity 0.8.17; import {IManager} from "aloe-ii-core/Borrower.sol"; contract SimpleManager is IManager { - function callback(bytes calldata data, address) external override returns (uint144) { + function callback(bytes calldata data, address, uint208) external override returns (uint208) { (bool success, ) = msg.sender.call(data); // solhint-disable-line avoid-low-level-calls require(success); return 0; diff --git a/periphery/src/managers/UniswapNFTManager.sol b/periphery/src/managers/UniswapNFTManager.sol index f83f7097..a95f783f 100644 --- a/periphery/src/managers/UniswapNFTManager.sol +++ b/periphery/src/managers/UniswapNFTManager.sol @@ -20,7 +20,7 @@ contract UniswapNFTManager is IManager { NFT_MANAGER = nftManager; } - function callback(bytes calldata data, address owner) external override returns (uint144 positions) { + function callback(bytes calldata data, address owner, uint208) external override returns (uint208 positions) { Borrower borrower = Borrower(payable(msg.sender)); // The ID of the NFT to which liquidity will be added/removed