-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Vis hangs trying to wrap awkward labels. #3429
Comments
Interesting. this should have been fixed with #3228, but you found a combination which breaks it again. It's the fourth which causes the infinite loop of course. The third I don't consider to be too critical, however the mentioned PR should have fixed that as well. Back to the drawing board. Thanks for reporting! |
The good news is that this has indeed been fixed with #3228: The bad news is that this fix has not been released yet; that was my confusion in my previous comment. You'll have to wait for the next release for the fix; if this fix is of critical importance to you, I can provide you an interim build of the |
Duplicate of #3171. |
@sawatts |
We can set a maximum width in the attributes of a node, group, or global options, and the documentation states that the labels will wrap on spaces to keep within the limit.
I have observed that labels that do not contain spaces force the node to be wider than the maximum. Thats fine - perhaps should be mentioned in the documentation though.
However there is an issue where a label contains spaces, but also contains words which are wider than the maximum. This appears to cause Vis to hang / go into an endless loop.
The following jsbin will demonstrate this - uncomment the maximum width from the options in the code and the script will hang. This example includes:
Presumably Vis is doing a check whether there are any spaces, but isn't doing a check on the word lengths thereafter?
The text was updated successfully, but these errors were encountered: