Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Network: Consistent node sizing options #3229

Open
cityy opened this issue Jul 3, 2017 · 1 comment
Open

Network: Consistent node sizing options #3229

cityy opened this issue Jul 3, 2017 · 1 comment

Comments

@cityy
Copy link

cityy commented Jul 3, 2017

Continuing the discussion from #3171

Currently, how you control the size of nodes depends on what node shape you are deploying. (size for image, circularImage, diamond, dot, star, triangle, triangleDown, square and icon; widthConstraint for all label based node shapes.

size:

The size is used to determine the size of node shapes that do not have the label inside of them. These shapes are: image, circularImage, diamond, dot, star, triangle, triangleDown, square and icon
http://visjs.org/docs/network/nodes.html

That's the behaviour I am referring to. Size should set the size, no matter what shape, for the sake of consistency. That way widthConstraint would become obsolete (there could still be something like min/max-size if required). Inheriting size from Label should be an option that can be true by default and considers min- / max-size.

@wimrijnders
Copy link
Contributor

I find this a very reasonable request, worth looking into. Consistency in usage is a beneficial thing.

However, I'm afraid I'm not going to pick it up any time soon, simply due to triage (bugs and priority stuff first). Of course, anyone else is free to have a go at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants