Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Endless Loop in Network if maxWdt < word #2953

Closed
mojoaxel opened this issue Apr 6, 2017 · 1 comment
Closed

Endless Loop in Network if maxWdt < word #2953

mojoaxel opened this issue Apr 6, 2017 · 1 comment
Assignees
@eymiha @ludost
Milestone
Patch Release v4....

Comments

@mojoaxel
Copy link
Member

mojoaxel commented Apr 6, 2017

From 8a9edbb#commitcomment-21618963

Hi @eymiha and @mojoaxel,

Just a quick heads-up: this commit goes into an unlimited loop when maxWdt < word length. Basically the >loop in: lib/network/modules/components/shared/Label.js#828 has no progress if 'w' is not incremented, >which happens if line 832 is true.
See: http://jsfiddle.net/ce92dhtx/72/ (if you uncomment the widthConstraint{ maximum} field it will go into >an unlimited loop)

I'll be able to create a fix later this week, but if one of you guys could fix it, even better.

Kind Regards,
Ludo..
@mojoaxel mojoaxel added this to the Minor Release v4.20 milestone Apr 6, 2017
mojoaxel referenced this issue Apr 6, 2017
@eymiha @mojoaxel
fix: Font styles and width and height of nodes (#2385)
8a9edbb 
* Multifont node and edge labels
* adjust documentation
* rework mod-font property inheritance
* Node max/min widths, min heights; Edge max widths
* Accumulate sizes correctly for unconstrained multipoint labels
* handle font.multi when groupOptions.font is not declared
* propagate label fonts on changes, not just creation
* Allow top-level constraint numbers
* accumulate width and empty lines appropriately
@wimrijnders wimrijnders mentioned this issue Apr 11, 2017
Closed
@wimrijnders wimrijnders mentioned this issue Apr 20, 2017
Closed
@mojoaxel mojoaxel modified the milestones: Minor Release v4.20, Patch Release v4.20.1 May 21, 2017
@wimrijnders
Copy link
Contributor

Duplicate of #3171.
Fixed by #3228.

@wimrijnders wimrijnders marked this as a duplicate of #3171 Jul 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eymiha eymiha

@ludost ludost

Labels
None yet
Projects
None yet
Milestone
Patch Release v4.20.2
Development

No branches or pull requests
4 participants
@eymiha @mojoaxel @wimrijnders @ludost