Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Pressing 'escape' on fullscreen attach closes opened test, not attach" #546 #641

Merged
merged 27 commits into from
Nov 14, 2017
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8ff6d0b
I have added postcss-rtl as a dev dependency in package.json and in w…
Jul 14, 2017
2dc4a79
Fixed some format issues
Jul 14, 2017
885f12e
Merge from allure2 master
Jul 16, 2017
293c2a6
Changes according the last merged pull request by just-boris (#476)
Jul 16, 2017
f4b97d6
Added copy to clipboard translation
Jul 16, 2017
bf2f924
in app.js I have added the line document.dir = i18next.dir(); it chan…
Aug 7, 2017
c3ec1a6
I have fixed conflicts and the arrows positions in the system (RTL)
Aug 7, 2017
0242ee0
Added Fullscreen translation
Aug 7, 2017
c640558
trying to push
Aug 7, 2017
39cb394
no message
Aug 7, 2017
71a1fa8
Merge
Aug 8, 2017
8f98e41
Merge branch 'master' into master
eroshenkoam Aug 9, 2017
1d3b167
Merge
Aug 10, 2017
7672d4b
Merge branch 'master' of https://github.com/allure-framework/allure2
Aug 20, 2017
1f4999c
I have replaced the tabs with 2 spaces indent and the vendor prefixes.
Aug 20, 2017
cf13fd1
I have fixed the indents
Aug 20, 2017
03f5d62
Merge branch 'master' of https://github.com/allure-framework/allure2
Aug 22, 2017
5c6b9fb
Merge branch 'master' of github.com:allure-framework/allure2
Sep 15, 2017
5892524
Merge branch 'master' of github.com:allure-framework/allure2
Oct 11, 2017
ffc341c
I have fixed "If user click on a test items, other previously opened …
Oct 17, 2017
74f61c2
I have fixed a bug in the restore that I have created in the pull req…
Oct 20, 2017
f2d686c
Changed from tabs to spaces
Oct 20, 2017
ae0625e
I have fixed pressing 'escape' on fullscreen attach closes opened tes…
Oct 20, 2017
a834687
merge from master
Oct 20, 2017
3a16b83
Merge branch 'master' of github.com:allure-framework/allure2 into All…
Oct 23, 2017
c1d8899
Removed unnecessary variable
Oct 26, 2017
8057201
Merge branch 'master' into AllureEscAttachment
baev Nov 14, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,12 @@ class TreeView extends View {
return;
}
if (current.testGroup && current.testResult) {
router.toUrl(`${this.baseUrl}/${current.testGroup}`);
if (this.routeState.get('attachment')) {
router.setSearch({attachment: null});
}
else{
router.toUrl(`${this.baseUrl}/${current.testGroup}`);
}
} else if (current.testGroup) {
router.toUrl(`${this.baseUrl}`);
}
Expand Down