Fix for "Pressing 'escape' on fullscreen attach closes opened test, not attach" #546 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebpack.config.js in order to support RTL. I have added the file rtl.css and I changed some css files in order to fix some RTL related issues. I have added a translation to Hebrew.
…ges the Dir according the language. I have added the Hebrew language. I fixed the arrows to work on RTL. I changed the side-by-side class to be RTL supported.
I replaced back the class name to side-by-side. I did RTL to the X values in the TrendChartView
…test packages also got expanded." allure-framework#575
…uest. Now it's working as intended
baev
approved these changes
Nov 14, 2017
|
@TpSr52 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I have fixed the bug "Pressing 'escape' on fullscreen attach closes opened test, not attach" #546
Checklist