use SASS instead of precss #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
just-boris
commented
Jul 15, 2017
| @@ -8,7 +8,7 @@ apply plugin: 'maven' | |||
| apply plugin: 'com.moowork.node' | |||
|
|
|||
| node { | |||
| version = '7.10.0' | |||
| version = '8.1.3' | |||
There was a problem hiding this comment.
Not necessary for this particular feature, but good to have
just-boris
commented
Jul 15, 2017
| ] | ||
| }) | ||
| }, { | ||
| test: /\.css$/, |
There was a problem hiding this comment.
we still support plain css files, that are imported from libraries (e.g. font-awesome)
just-boris
commented
Jul 15, 2017
| @@ -7,8 +7,6 @@ const postcssLoader = { | |||
| loader: 'postcss-loader', | |||
| options: { | |||
| plugins: [ | |||
| require('postcss-import'), | |||
| require('precss')({'import': {disable: true}}), | |||
| require('autoprefixer') | |||
There was a problem hiding this comment.
PostCSS is still used, as we want to have autoprefixer. (To have less pain supporting IE and Safari)
baev
approved these changes
Jul 16, 2017
|
@just-boris thanks! |
TpSr52
pushed a commit
to TpSr52/allure2
that referenced
this pull request
Jul 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no future in precss, also it makes use some problems in development, like bad support in Idea.
Sass would be better there.