Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom attachment content types #221

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

just-boris
Copy link
Contributor

@just-boris just-boris commented Nov 13, 2020

This is the Javascript integration for this feature: allure-framework/allure2#1145

Currently only pre-defined content types are supported, this PR adds custom types:

allure.attachment('screen diff', screenDiffJson, {
   contentType: 'application/vnd.allure.image.diff',
   fileExtension: 'json' // no auto-detect, because `file-type` npm module has async API, but our method is sync
})

@just-boris
Copy link
Contributor Author

Could @baev or @sseliverstov check this PR? it is needed to leverage the new screen diff improvements in JS frameworks

@baev baev merged commit dbce900 into allure-framework:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants